🐛(api) fix not thread-safe database session singleton #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
added
bug
The singleton pattern is not thread-safe leading to database session inconsistency during server heavy load (expired sessions, etc.) See raised errors in SQLAlchemy docuementation: https://docs.sqlalchemy.org/en/20/errors.html#error-bhk3
jmaupetit
force-pushed
the
api-improve-db-session-management
branch
from
c692105 to
a07c905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The singleton pattern is not thread-safe leading to database session inconsistency during server heavy load (expired sessions, etc.)
See raised errors in SQLAlchemy docuementation: https://docs.sqlalchemy.org/en/20/errors.html#error-bhk3
Proposal
Get a new session everytime it needs to be injected. Hope this won't create too many database connections.